fix(NODE-4533): session support error message and unified test runner#3355
Merged
fix(NODE-4533): session support error message and unified test runner#3355
Conversation
dariakp
commented
Aug 12, 2022
93060c5 to
648212c
Compare
baileympearson
requested changes
Aug 15, 2022
Contributor
baileympearson
left a comment
There was a problem hiding this comment.
Requesting changes for visibility but only two minor comments.
163c00c to
a88b730
Compare
baileympearson
previously approved these changes
Aug 16, 2022
nbbeeken
previously approved these changes
Aug 16, 2022
nbbeeken
approved these changes
Aug 16, 2022
baileympearson
approved these changes
Aug 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NODE-4533 for NODE-4325
What is changing?
isErrororisClientError)MongoCryptError- these aren't standardized in the fle module, so it's a bit awkward, see comment for further discussionIs there new documentation needed for these changes?
No
What is the motivation for this change?
Splitting up groundwork from the sdam-specific unified changes
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>